Harden some tests; fix a typo. #775
Merged
+62
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert some of the throttle tests to use sinon timers for more reliable testing. Fix some tutorial tests since Chrome 64 changed srcdoc in iframe usage. Harden the test to check if a video is ready to play.
Merged
|
I'll note that in travis, we can't just pin to Chrome 63 for testing. You can only use |
matthewma7
approved these changes
Feb 12, 2018
|
I'll go ahead and merge. If we decide we should have done something different, we can make another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert some of the throttle tests to use sinon timers for more reliable testing.
Fix some tutorial tests since Chrome 64 changed srcdoc in iframe usage.
Harden the test to check if a video is ready to play.